Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: Use full URL in the og:image property #4675

Merged
merged 1 commit into from
Jul 10, 2024
Merged

HTML: Use full URL in the og:image property #4675

merged 1 commit into from
Jul 10, 2024

Conversation

Fijxu
Copy link
Contributor

@Fijxu Fijxu commented May 2, 2024

Some opengraph implementations don't support a URL without the domain therefore failing to fetch the video thumbnail and channel image. This pull request basically fixes that.

@Fijxu Fijxu requested a review from a team as a code owner May 2, 2024 02:26
@Fijxu Fijxu requested review from syeopite and removed request for a team May 2, 2024 02:26
SamantazFox
SamantazFox reviewed May 10, 2024
View reviewed changes
Copy link
Member

@SamantazFox SamantazFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks :)

@SamantazFox SamantazFox added need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something in-testing This feature has been deployed and is being tested and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels May 10, 2024
@SamantazFox SamantazFox added ready and removed in-testing This feature has been deployed and is being tested labels Jun 15, 2024
@SamantazFox SamantazFox changed the title Use full URL in the og:image property. HTML: Use full URL in the og:image property Jul 10, 2024
@SamantazFox SamantazFox merged commit e9bab06 into iv-org:master Jul 10, 2024
7 checks passed
@SamantazFox
Copy link
Member

Thanks for the PR :D

@Fijxu Fijxu deleted the opengraph-thumbnail branch July 10, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamantazFox SamantazFox SamantazFox approved these changes

@syeopite syeopite Awaiting requested review from syeopite syeopite is a code owner automatically assigned from iv-org/developers

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fijxu @SamantazFox