-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Videos: Use android test suite client #4650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixfox
requested changes
Apr 26, 2024
We should also use the IOS client for getting the missing pieces. From my draft: if !new_player_response.nil?
client_config.client_type = YoutubeAPI::ClientType::IOS
new_player_response_ios = try_fetch_streaming_data(video_id, client_config)
if !new_player_response_ios.nil?
puts typeof(new_player_response["streamingData"])
adaptiveFormats_to_merge = new_player_response.dig("streamingData", "adaptiveFormats")
adaptiveFormats_to_merge_ios = new_player_response_ios.dig("streamingData", "adaptiveFormats")
#puts adaptiveFormats_to_merge
puts "-----------------------------------------------------------------"
puts adaptiveFormats_to_merge_ios.as_h
puts typeof(adaptiveFormats_to_merge_ios)
#adaptiveFormats_to_merge.as_h.merge(adaptiveFormats_to_merge_ios.as_h)
#new_player_response["streamingData"] = streamingData_to_merge["streamingData"]
new_player_response["captions"] = new_player_response_ios["captions"]
new_player_response["storyboards"] = new_player_response_ios["storyboards"]
end
# Preserve storyboard data before replacement
new_player_response["storyboards"] = player_response["storyboards"] if player_response["storyboards"]?
player_response = new_player_response
#puts player_response["streamingData"]
params.delete("reason")
end |
@unixfox I realized we don't need the storyboards from the IOS client, as we already extract those from the original WEB client request: invidious/src/invidious/videos/parser.cr Lines 124 to 131 in b673695
All we have to do is also copy the captions over |
unixfox
approved these changes
Apr 26, 2024
syeopite
approved these changes
Apr 26, 2024
unixfox
requested changes
Apr 26, 2024
unixfox
approved these changes
Apr 26, 2024
Closed
13 tasks
user234683
added a commit
to user234683/youtube-local
that referenced
this pull request
Jun 8, 2024
Invidious' solution to the destruction of the android client: iv-org/invidious#4650 Fixes #207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until a better and more permanent solution is found...
At least, it allows playing regular videos.
Closes #4584