Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences: Fix handling of modified source code URL #4437

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Preferences: Fix handling of modified source code URL #4437

merged 1 commit into from
Jul 21, 2024

Conversation

nooptek
Copy link
Contributor

@nooptek nooptek commented Feb 18, 2024

Currently, setting the modified code repo URL through the preferences page in Invidious is broken.

  • the HTML input tag for this field has invalid type "input" (though browser falls back on text input)
  • the URL is used to set the "checked" property and not as a plain value, which makes no sense for a text-based input (and results in a blank field)
  • when the submitted field is empty, the retrieved value is an empty String instead of nil, causing the "modified source code URL" being an empty href link which just points to the current page

@nooptek nooptek requested a review from a team as a code owner February 18, 2024 21:46
@nooptek nooptek requested review from unixfox and removed request for a team February 18, 2024 21:46
@nooptek nooptek force-pushed the fix-modified-repo-url branch from 6a526de to 499aed3 Compare March 10, 2024 16:52
SamantazFox
SamantazFox approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@SamantazFox SamantazFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! And sorry for taking so long to review ^^

@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Apr 24, 2024
@SamantazFox SamantazFox added in-testing This feature has been deployed and is being tested ready and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something in-testing This feature has been deployed and is being tested labels Jul 17, 2024
@SamantazFox SamantazFox changed the title Fix handling of modified source code URL setting Preferences: Fix handling of modified source code URL Jul 21, 2024
@SamantazFox SamantazFox merged commit 8b1da20 into iv-org:master Jul 21, 2024
7 checks passed
@SamantazFox
Copy link
Member

Thanks for the PR :D

@nooptek nooptek deleted the fix-modified-repo-url branch July 27, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamantazFox SamantazFox SamantazFox approved these changes

@unixfox unixfox Awaiting requested review from unixfox unixfox is a code owner automatically assigned from iv-org/developers

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nooptek @SamantazFox