-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Fix error code for disabled popular endpoint #4296
Conversation
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
Bump |
I don't know what changed, but /api/v1/popular now returns
Closing |
The PR should probably still be kept to change the HTTP status code from 400 to 403. The former doesn't exactly fit for a disabled endpoint |
This reverts commit 1363fb8.
…lar-disabled-error
Fair - updated PR |
Thanks for the fix! |
When visiting /api/v1/popular and popular endpoint is disabled
Before:
After