Add workaround for storyboards on local instances #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An upstream problem with videojs-vtt-thumbnails means that URLs gets joined incorrectly on any instance where `domain`, `external_port` and `https_only` aren't set. This commit adds some logic with the 404 handler to mitigate this problem. This is however only a workaround. See: iv-org#3117 chrisboustead/videojs-vtt-thumbnails#31
PR iv-org#4037 introduced a workaround around YouTube's new integrity checks on streaming URLs. However, the usage of this workaround prevents storyboard data from being returned by InnerTube. This commit fixes that by only using the workaround when calling try_fetch_streaming_data
This was referenced Aug 8, 2023
SamantazFox
approved these changes
Aug 21, 2023
SamantazFox
added
the
need-testing
|
Tested it, works good. If I comment/unset the 3 settings that @syeopite mentions, storyboards appear without problems when connecting locally to the instance and via the HTTPS domain. However if I set the 3 settings mentioned, storyboards no longer work when connecting locally but they work if I connect via the HTTPS domain. I guess this is the intended purpose of this pull request
|
syeopite
added
ready
and removed
need-testing
|
@syeopite Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3117
Also fixes a regression from #4037 that broke storyboards for everyone.
This PR adds a quick workaround within the 404 handler to allow storyboards to function on instances without
domain,external_portandhttps_onlyset.We should probably consider switching to the freetube fork here