For android client send sdk version to youtube #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixfox
force-pushed
the
fix-content-not-available
branch
2 times, most recently
from
fadcada to
ce95d52
Compare
SamantazFox
reviewed
Aug 7, 2022
App versions and Android's SDK versions are completely different and always independent. App version does increment on app updates and SDK version does on system updates. In theory you can set |
unixfox
force-pushed
the
fix-content-not-available
branch
from
ce95d52 to
444f614
Compare
SamantazFox
reviewed
Aug 7, 2022
unixfox
force-pushed
the
fix-content-not-available
branch
2 times, most recently
from
0369d7c to
92a4aef
Compare
unixfox
force-pushed
the
fix-content-not-available
branch
from
92a4aef to
218f7be
Compare
SamantazFox
approved these changes
Aug 7, 2022
|
I've not seen this error from #3230 since, except today where I tried to watch a video and it came up, so it looks like in certain circumstances it's still possible? Was the debug thing not added, where if the video that comes back isn't the video id requested to throw some kind of exception? |
|
Please continue the discussion in #3230 instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, when using the ANDROID client, we send the
androidSdkVersionalongside, in order to tell Youtube servers that we are using a recent Android version. The number29equals to the android API level, which is Android 10.I've included the
29Android API level instead of30because the clientVersion that we are using right now include29as it seems like the sdk version.This fixes the error
Content not available in this app. upgrade to latest version of youtube..The new parameter was found in TeamNewPipe/NewPipe#8713 (comment)
Fixes #3230