Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using C++20's std::span -based Interface #16

Merged
merged 27 commits into from
Jan 13, 2024
Merged

Switch to using C++20's std::span -based Interface #16

merged 27 commits into from
Jan 13, 2024

Conversation

itzmeanjan
Copy link
Owner

@itzmeanjan itzmeanjan commented Jan 11, 2024 •
edited
Loading

  • Rewrite Sphincs+ to use C++20's std::span based interface
  • Update all tests and benchmarks
  • Update benchmarks results

@itzmeanjan
extract out compile-time executable parameter checker function to the…
6c53154 
…ir own header file and namespace

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
bump git submodule based dependency sha3 to latest git commit
4541724 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
implement new pseudo random number generator using SHAKE128 Xof
7e847c7 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
update hashing module to use new API of dependency sha3
768d9b4 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
update API usage demonstration program to work with new sha3 API
96348e0 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
ensure that header files in benchmark directory are clang formatted
a40de10 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor utility functions to use std::span based interface
74f3aa8 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor ADRS structs and functions to use std::span based interface
48ae61a 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor all hashing related functions to use std::span based interface
edb429b 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor one-time signature scheme WOTS+ to use std::span based inter…
992c31c 
…face

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor XMSS implementation to use std::span based interface
f0efd97 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor FORS implementation to use std::span based interface
f381999 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor HyperTree implementation to use std::span based interface
00c4685 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
refactor Sphincs+ generic keygen, sign and verify functions to use st…
af7fed4 
…d::span based interface

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
begin using new std::span based API for Sphincs+ instantiations
21cc7c6 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
begin using new std::span based interface for Sphincs+ instantiations…
d6aa5ce 
…, when benchmarking the header-only library implementation

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
address compilation failure issues encountered during building benchm…
12da078 
…ark binary

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
compute minimum and maximum statistics when benchmarking keygen, sign…
d0c02d9 
… and verify functions for various instantiations of Sphincs+

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
prefer simpler arithmetic instead of bit shift operator in compile-ti…
24e3847 
…me computed constants

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
pass flag, denoting intention of generating randomized message signat…
224a471 
…ure, to downstream functions

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
avoid directing compiler to unroll loops when it's not safe
069f462 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
update tests to use new std::span based API
80331c7 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
fix to_byte function implementation
c80026f 
Didn't handle the case *correctly*, if resulting byte array has lesser (i.e. <=4) byte length compared to byte length of source word (32 -bit).

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
update benchmark results
7327d92 
Add benchmark results from Raspberry Pi 4B

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
add gtest-parallel as git submodule based dependency
2ce6bb8 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
run tests using gtest-parallel
95ad1be 
Seeing *huge* 🚀 improvements

Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
update sphincs+ API usage example, reflect changes on README too
ce1acd2 
Signed-off-by: Anjan Roy <[email protected]>
@itzmeanjan
Copy link
Owner Author

itzmeanjan commented Jan 13, 2024 •
edited
Loading

Commit 95ad1be, brings huge performance improvements in running time of tests.

BEFORE Taking ~1583.025 seconds to run all 27 tests.

Screenshot from 2024-01-13 14-22-33

AFTER Taking ~529.956 seconds to run equal many tests.

Screenshot from 2024-01-13 14-24-17

That's ~66.52% reduction in running time of tests. Seeing this result on a x86_64 machine with 16 online CPUs, running GNU/ Linux kernel 6.5.0-14-generic.

@itzmeanjan itzmeanjan merged commit 9e76ee0 into master Jan 13, 2024
2 checks passed
@itzmeanjan itzmeanjan deleted the switch-to-using-std-span branch January 13, 2024 11:21
itzmeanjan added a commit that referenced this pull request Jan 23, 2024
@itzmeanjan
Merge pull request #16 from itzmeanjan/switch-to-using-std-span
ae142b6 
Switch to using C++20's `std::span` -based Interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@itzmeanjan