Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fraunhofer test files fail with "invalid channel configuration" #74

Closed
MarkerB opened this issue Feb 12, 2024 · 2 comments
Closed

Fraunhofer test files fail with "invalid channel configuration" #74

MarkerB opened this issue Feb 12, 2024 · 2 comments
Assignees

Comments

@MarkerB
Copy link

MarkerB commented Feb 12, 2024

I'm trying to verify the channel layout using the Fraunhofer "test signal" files, and the ia_mpeghd_testbench conversion fails with the error "invalid channel configuration". It fails no matter what channel layout I use on the command line. I've tried a "cicp" of 20, 19, and 7.

The Fraunhofer test files are located at https://mpegh.com/test-signals/, and I've specifically tried "Channel Identification: 7.1 + 4 Speakers".

I've been able to convert other mp4 wrapped MPEG-H files without incident, but I don't quite trust the channel mappings I'm getting. All my input files have the order "L R C LFE Lb Rb Lss Rss Tfl Tfr Tbl Tbr", but it would be great to hear a test for sure.

@SakethSathuvalli SakethSathuvalli self-assigned this Feb 14, 2024
@SakethSathuvalli
Copy link
Member

Hi @MarkerB,

Thanks for bringing this to our notice!

A quick fix is available on the branch - https://github.com/ittiam-systems/libmpegh/tree/74-fix-mp4-parse-issue

It will take us sometime (~1-2 weeks) to bring it on to main branch post testing and validation.

Thanks!

@MarkerB
Copy link
Author

MarkerB commented Feb 14, 2024

A quick fix is available on the branch - https://github.com/ittiam-systems/libmpegh/tree/74-fix-mp4-parse-issue

Wonderful! I had been using the ready-made Windows executable, so I had to install Visual Studio Community... but now I can convert those test files from Fraunhofer. Thank you so much!

SakethSathuvalli added a commit that referenced this issue Feb 15, 2024
[x] Changes also contain some a fix in configuration data parsing path.
[x] Minor clean-up in testbench related to frame counter updation.

Tests: TBD
SakethSathuvalli added a commit that referenced this issue Feb 27, 2024
Significance:
=============
[x] Changes also contain some a fix in configuration data parsing path.
[x] Minor clean-up in testbench related to frame counter updation.

Tests:
======
[x] x86 build tested for conformance
SakethSathuvalli added a commit that referenced this issue Feb 28, 2024
Significance:
=============
[x] Changes also contain some a fix in configuration data parsing path.
[x] Minor clean-up in testbench related to frame counter updation.

Tests:
======
[x] x86 build tested for conformance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants