feat : Fix bugs and improve fairness in RPS game #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the issue #1
Bug Fix:
Replaced the invalid call to move() with move in the input validation logic.
Ensured that user inputs like 'R', 'P', 'S' are correctly handled using strip() and lower().
Fairness Improvement:
Verified the randomness of the computer's move using the random.choice() function.
Enhanced transparency by displaying both user and computer moves before announcing the result.
Code Clarity:
Refactored user move selection using a dictionary for better readability.
Improved input validation and error messaging for invalid inputs
Changes Made
Updated the input validation logic to prevent TypeError.
Added a mapping for user inputs ('r', 'p', 's') to game moves (rock, paper, scissor).
Improved feedback and ensured accurate winner determination with updated find_winner logic.
Enhanced input handling with strip() and lower() to remove extra spaces and handle capitalization.
Screenshot
Can you please review the changes @itsallaboutpython . Thank you!!