Skip to content

Commit

Permalink
fix: broken build (aws-samples#255)
Browse files Browse the repository at this point in the history
* update Cognito example to incorporate the recent breaking change.
* eks/cluster typescript project to exclude re-compiling dependencies in
  `node_modules/`.
  • Loading branch information
nija-at authored Mar 6, 2020
1 parent 0d66006 commit a3359d7
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
6 changes: 4 additions & 2 deletions typescript/cognito-api-lambda/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { LambdaRestApi, CfnAuthorizer, LambdaIntegration, AuthorizationType } from '@aws-cdk/aws-apigateway';
import { AssetCode, Function, Runtime } from '@aws-cdk/aws-lambda';
import { App, Stack } from '@aws-cdk/core';
import { UserPool, SignInType } from '@aws-cdk/aws-cognito'
import { UserPool } from '@aws-cdk/aws-cognito'

export class CognitoProtectedApi extends Stack {
constructor(app: App, id: string) {
Expand All @@ -23,7 +23,9 @@ export class CognitoProtectedApi extends Stack {

// Cognito User Pool with Email Sign-in Type.
const userPool = new UserPool(this, 'userPool', {
signInType: SignInType.EMAIL
signInAliases: {
email: true
}
})

// Authorizer for the Hello World API that uses the
Expand Down
2 changes: 1 addition & 1 deletion typescript/eks/cluster/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class EKSCluster extends cdk.Stack {
instanceType: new ec2.InstanceType('t3.medium'),
machineImage: new eks.EksOptimizedImage({
kubernetesVersion: '1.14',
nodeType: eks.NodeType.STANDARD // wihtout this, incorrect SSM parameter for AMI is resolved
nodeType: eks.NodeType.STANDARD // without this, incorrect SSM parameter for AMI is resolved
}),
updateType: autoscaling.UpdateType.ROLLING_UPDATE
});
Expand Down
8 changes: 6 additions & 2 deletions typescript/eks/cluster/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,9 @@
"inlineSources": true,
"experimentalDecorators": true,
"strictPropertyInitialization":false
}
}
},
"include": [ "**/*.ts" ],
"exclude": [
"**/*.d.ts"
]
}

0 comments on commit a3359d7

Please sign in to comment.