Skip to content

Commit

Permalink
fix: broken build (aws-samples#225)
Browse files Browse the repository at this point in the history
The resource-overrides code build was broken because desiredCapacity is
not calculated all of the time.

Ref: aws/aws-cdk@0adf6c7#diff-ab28b1e5c6b252f017045680eb86f108

Also, outputting the current project being built into STDOUT for better
future diagnosis.
  • Loading branch information
nija-at authored and mergify[bot] committed Jan 10, 2020
1 parent 29efbdb commit 9a6f14c
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@
"Properties": {
"MaxSize": "1",
"MinSize": "1",
"DesiredCapacity": "1",
"LaunchConfigurationName": {
"Ref": "ASGLaunchConfigC00AF12B"
},
Expand Down
1 change: 1 addition & 0 deletions scripts/build-java.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ npm install
for pomFile in $(find $scriptdir/../java -name pom.xml); do
(
cd $(dirname $pomFile)
echo "Building project at $(dirname $pomFile)"
mvn compile test

$scriptdir/synth.sh
Expand Down
1 change: 1 addition & 0 deletions scripts/build-npm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ verify_star_dependencies() {
# Find and build all NPM projects
for pkgJson in $(find typescript -name package.json | grep -v node_modules); do
(
echo "Building project at $(dirname $pkgJson)"
cd $(dirname $pkgJson)

if [[ -f DO_NOT_AUTOTEST ]]; then exit 0; fi
Expand Down
1 change: 1 addition & 0 deletions scripts/build-python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ for requirements in $(find $scriptdir/../python -name requirements.txt -not -pa
echo "=============================="

cd $(dirname $requirements)
echo "Building project at $(dirname $requirements)"
[[ ! -f DO_NOT_AUTOTEST ]] || exit 0

source /tmp/.venv/bin/activate
Expand Down

0 comments on commit 9a6f14c

Please sign in to comment.