⚡ mail_private New: internal users are flagged automatically #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolushovAlexandr
suggested changes
Aug 13, 2019
mail_private/models.py
Outdated
|
|
||
| recipient_ids = [r.partner_id for r in follower_ids if r.partner_id] | ||
| # channel_ids = [c.channel_id for c in follower_ids if c.channel_id] | ||
|
|
||
| for recipient in recipient_ids: | ||
| result.append({ | ||
| 'checked': len(recipient.user_ids) > 0, | ||
| 'checked': recipient.user_ids.id in internal_ids, |
There was a problem hiding this comment.
I could suggest smth like
not any(recipient.user_ids.mapped('share'))
so there is no need in get_internal_users_ids method
Ommo73
force-pushed
the
12.0-mail_private-internal_users_checked
branch
from
d5c62e0 to
dc184cc
Compare
KolushovAlexandr
approved these changes
Aug 14, 2019
Ramil-Mukhametzyanov
approved these changes
Aug 26, 2019
em230418
suggested changes
Aug 26, 2019
There was a problem hiding this comment.
- Захожу как админ
- Discuss -> Direct Messages
- Добавляю Marc Demo
- Нажимаю на шестеренку
- Скроллю вниз, нажимаю на Send Internal message
- Ввожу сообщение, нажимаю send. Появляется ошибка: TypeError: self.fields.thread is undefined
- Надо в changelog добавить, что исправили. Соотвественно версию поднять
Первый сценарий покрыть тестом
kaadevelop
reviewed
Aug 28, 2019
There was a problem hiding this comment.
2 installable modules are updated:
├─ mail_multi_website/
| ├─ README.rst
| ├─ __manifest__.py
| ├─ doc/
| | └─ index.rst
| └─ static/
| └─ description/
| └─ index.html
└─ mail_private/
├─ models.py
└─ static/
└─ src/
└─ xml/
└─ mail_private.xml
Not installable modules remain unchanged.
No new features in doc/changelog.rst files of installable modules
sent by review-bot
скрыл эту кнопку на страницах настроек канала, она там не нужна |
em230418
suggested changes
Sep 10, 2019
Ommo73
force-pushed
the
12.0-mail_private-internal_users_checked
branch
from
d93aa10 to
bb21f42
Compare
itpp-bot
reviewed
Sep 20, 2019
There was a problem hiding this comment.
2 installable modules are updated:
├─ mail_multi_website/
| ├─ README.rst
| ├─ __manifest__.py
| ├─ doc/
| | └─ index.rst
| └─ static/
| └─ description/
| └─ index.html
└─ mail_private/
├─ __manifest__.py
├─ doc/
| └─ changelog.rst
├─ models.py
└─ static/
└─ src/
└─ xml/
└─ mail_private.xml
Not installable modules remain unchanged.
sent by ✌️ Odoo Review Bot
| ------- | ||
|
|
||
| - **Improvement:** refactoring code | ||
|
|
Ommo73
force-pushed
the
12.0-mail_private-internal_users_checked
branch
from
bb21f42 to
ee4c0bd
Compare
|
I approve to merge it now |
|
Approved by @em230418
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.