Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update rust crate cargo to v0.72.2 [security] - autoclosed #63

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 3, 2023

This PR contains the following updates:

Package Type Update Change
cargo (source) dependencies patch 0.72.1 -> 0.72.2

GitHub Vulnerability Alerts

CVE-2023-38497

The Rust Security Response WG was notified that Cargo did not respect the umask when extracting crate archives on UNIX-like systems. If the user downloaded a crate containing files writeable by any local user, another local user could exploit this to change the source code compiled and executed by the current user.

This vulnerability has been assigned CVE-2023-38497.

Overview

In UNIX-like systems, each file has three sets of permissions: for the user owning the file, for the group owning the file, and for all other local users. The "umask" is configured on most systems to limit those permissions during file creation, removing dangerous ones. For example, the default umask on macOS and most Linux distributions only allow the user owning a file to write to it, preventing the group owning it or other local users from doing the same.

When a dependency is downloaded by Cargo, its source code has to be extracted on disk to allow the Rust compiler to read as part of the build. To improve performance, this extraction only happens the first time a dependency is used, caching the pre-extracted files for future invocations.

Unfortunately, it was discovered that Cargo did not respect the umask during extraction, and propagated the permissions stored in the crate archive as-is. If an archive contained files writeable by any user on the system (and the system configuration didn't prevent writes through other security measures), another local user on the system could replace or tweak the source code of a dependency, potentially achieving code execution the next time the project is compiled.

Affected Versions

All Rust versions before 1.71.1 on UNIX-like systems (like macOS and Linux) are affected. Note that additional system-dependent security measures configured on the local system might prevent the vulnerability from being exploited.

Users on Windows and other non-UNIX-like systems are not affected.

Mitigations

We recommend all users to update to Rust 1.71.1, which will be released later today, as it fixes the vulnerability by respecting the umask when extracting crate archives. If you build your own toolchain, patches for 1.71.0 source tarballs are available here.

To prevent existing cached extractions from being exploitable, the Cargo binary included in Rust 1.71.1 or later will purge the caches it tries to access if they were generated by older Cargo versions.

If you cannot update to Rust 1.71.1, we recommend configuring your system to prevent other local users from accessing the Cargo directory, usually located in ~/.cargo:

chmod go= ~/.cargo

Acknowledgments

We want to thank Addison Crump for responsibly disclosing this to us according to the Rust security policy.

We also want to thank the members of the Rust project who helped us disclose the vulnerability: Weihang Lo for developing the fix; Eric Huss for reviewing the fix; Pietro Albini for writing this advisory; Pietro Albini, Manish Goregaokar and Josh Stone for coordinating this disclosure; Josh Triplett, Arlo Siemen, Scott Schafer, and Jacob Finkelman for advising during the disclosure.


Release Notes

rust-lang/cargo (cargo)

v0.72.2

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title fix(deps): update rust crate cargo to 0.75 [security] fix(deps): update rust crate cargo to 0.75 [security] - autoclosed Dec 3, 2023
@renovate renovate bot closed this Dec 3, 2023
@renovate renovate bot deleted the renovate/crate-cargo-vulnerability branch December 3, 2023 16:20
@renovate renovate bot changed the title fix(deps): update rust crate cargo to 0.75 [security] - autoclosed fix(deps): update rust crate cargo to 0.75 [security] Dec 6, 2023
@renovate renovate bot reopened this Dec 6, 2023
@renovate renovate bot restored the renovate/crate-cargo-vulnerability branch December 6, 2023 13:50
@renovate renovate bot force-pushed the renovate/crate-cargo-vulnerability branch from 27777e1 to 9f9cafe Compare December 6, 2023 13:50
@renovate renovate bot changed the title fix(deps): update rust crate cargo to 0.75 [security] fix(deps): update rust crate cargo to v0.72.2 [security] Dec 6, 2023
@richarddd
Copy link

richarddd commented Aug 4, 2024

@mettke can we update the dependencies please? Cargo patch doesn't work on latest nightly:

error[E0283]: type annotations needed
   --> /Users/ridaviso/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-url-0.18.0/src/lib.rs:105:54
    |
105 |             let path = gix_path::from_bstr(self.path.as_ref());
    |                                                      ^^^^^^
    |
    = note: multiple `impl`s satisfying `BString: AsRef<_>` found in the `bstr` crate:
            - impl AsRef<BStr> for BString;
            - impl AsRef<[u8]> for BString;
help: try using a fully qualified path to specify the expected types
    |
105 |             let path = gix_path::from_bstr(<BString as AsRef<T>>::as_ref(&self.path));
    |                                            +++++++++++++++++++++++++++++++         ~

error[E0283]: type annotations needed
   --> /Users/ridaviso/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-url-0.18.0/src/lib.rs:105:24
    |
105 |             let path = gix_path::from_bstr(self.path.as_ref());
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot infer type for reference `&_`
    |
    = note: multiple `impl`s satisfying `Cow<'_, BStr>: From<&_>` found in the `bstr` crate:
            - impl<'a> From<&'a BStr> for Cow<'a, BStr>;
            - impl<'a> From<&'a BString> for Cow<'a, BStr>;
    = note: required for `&_` to implement `Into<Cow<'_, BStr>>`
note: required by a bound in `from_bstr`
   --> /Users/ridaviso/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-path-0.8.4/src/convert.rs:126:34
    |
126 | pub fn from_bstr<'a>(input: impl Into<Cow<'a, BStr>>) -> Cow<'a, Path> {
    |                                  ^^^^^^^^^^^^^^^^^^^ required by this bound in `from_bstr`

warning: `tracing-core` (lib) generated 10 warnings
       Fresh litemap v0.7.3
For more information about this error, try `rustc --explain E0283`.
error: could not compile `gix-url` (lib) due to 2 previous errors

@HKMV
Copy link

HKMV commented Aug 8, 2024

@mettke can we update the dependencies please? Cargo patch doesn't work on latest nightly:

error[E0283]: type annotations needed
   --> /Users/ridaviso/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-url-0.18.0/src/lib.rs:105:54
    |
105 |             let path = gix_path::from_bstr(self.path.as_ref());
    |                                                      ^^^^^^
    |
    = note: multiple `impl`s satisfying `BString: AsRef<_>` found in the `bstr` crate:
            - impl AsRef<BStr> for BString;
            - impl AsRef<[u8]> for BString;
help: try using a fully qualified path to specify the expected types
    |
105 |             let path = gix_path::from_bstr(<BString as AsRef<T>>::as_ref(&self.path));
    |                                            +++++++++++++++++++++++++++++++         ~

error[E0283]: type annotations needed
   --> /Users/ridaviso/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-url-0.18.0/src/lib.rs:105:24
    |
105 |             let path = gix_path::from_bstr(self.path.as_ref());
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot infer type for reference `&_`
    |
    = note: multiple `impl`s satisfying `Cow<'_, BStr>: From<&_>` found in the `bstr` crate:
            - impl<'a> From<&'a BStr> for Cow<'a, BStr>;
            - impl<'a> From<&'a BString> for Cow<'a, BStr>;
    = note: required for `&_` to implement `Into<Cow<'_, BStr>>`
note: required by a bound in `from_bstr`
   --> /Users/ridaviso/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-path-0.8.4/src/convert.rs:126:34
    |
126 | pub fn from_bstr<'a>(input: impl Into<Cow<'a, BStr>>) -> Cow<'a, Path> {
    |                                  ^^^^^^^^^^^^^^^^^^^ required by this bound in `from_bstr`

warning: `tracing-core` (lib) generated 10 warnings
       Fresh litemap v0.7.3
For more information about this error, try `rustc --explain E0283`.
error: could not compile `gix-url` (lib) due to 2 previous errors

I also encountered this problem

@renovate renovate bot changed the title fix(deps): update rust crate cargo to v0.72.2 [security] fix(deps): update rust crate cargo to v0.72.2 [security] - autoclosed Sep 19, 2024
@renovate renovate bot closed this Sep 19, 2024
@renovate renovate bot deleted the renovate/crate-cargo-vulnerability branch September 19, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants