completeHandlerIOS now return a promise so you can await for it

itinance · Sep 4, 2017 · fefd456 · fefd456
1 parent f58f726
commit fefd456
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/FS.common.js b/FS.common.js
@@ -225,7 +225,7 @@ var RNFS = {
   },
 
   completeHandlerIOS(jobId: number): void {
-    RNFSManager.completeHandlerIOS(jobId);
+    return RNFSManager.completeHandlerIOS(jobId);
   },
 
   readDir(dirpath: string): Promise<ReadDirItem[]> {

diff --git a/RNFSManager.m b/RNFSManager.m
@@ -508,17 +508,19 @@ - (dispatch_queue_t)methodQueue
     }
 }
 
-RCT_EXPORT_METHOD(completeHandlerIOS:(nonnull NSNumber *)jobId)
+RCT_EXPORT_METHOD(completeHandlerIOS:(nonnull NSNumber *)jobId
+                  resolver:(RCTPromiseResolveBlock)resolve
+                  rejecter:(RCTPromiseRejectBlock)reject)
 {
     if (self.uuids) {
         NSString *uuid = [self.uuids objectForKey:[jobId stringValue]];
         CompletionHandler completionHandler = [completionHandlers objectForKey:uuid];
         if (completionHandler) {
-            NSLog(@"Calling completion handler on: %@", uuid);
             completionHandler();
             [completionHandlers removeObjectForKey:uuid];
         }
     }
+    resolve(nil);
 }
 
 RCT_EXPORT_METHOD(uploadFiles:(NSDictionary *)options