fix(storybook): update Babel configuration #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The React Storybook is failing to build because when Storybook attempts to build, it looks for a Babel configuration, and for story files it's ascending and finding the root `babel.config.js` file and using only its configuration. Namely, this doesn't include the React preset, and the build fails to understand JSX syntax as a result. Storybook offers a `babel` function for manipulating the Babel configuration as a preferred approach, so this change moves the desired configuration to the Storybook config and deletes the root Babel config file, which was added mainly to appease the build earlier on. - Also bumped Storybook + addons to the latest v7 release. - Also added Netlify status badges to the README so these things go unnoticed less often.
daneah
requested review from
brentswisher,
sirrah-tam and
mtorres3
and removed request for
a team
|
brentswisher
approved these changes
Mar 8, 2024
size-limit report 📦
|
daneah
added a commit
that referenced
this pull request
Mar 8, 2024
* develop: (77 commits) chore(deps): update GitHub Actions and Node versions (#704) fix(site): use Pharos v14 properties (#703) fix(storybook): update Babel configuration (#702) fix(infra): use Node 18 in .nvmrc (#701) fix(infra): update dependencies fix(infra): allow mutable Yarn lockfile during release for workspaces versions Version Packages (#700) Release/14.0.0 (#697) chore(deps): upgrade to Yarn 4 (#694) chore(deps): bump es5-ext from 0.10.62 to 0.10.64 (#692) fix(icon): add media query style for WHCM (#689) chore(deps): bump ip from 1.1.8 to 1.1.9 (#687) chore: version packages (#685) Icon: Add "add to folder" icon (#678) Fix the all-contributors badge (#680) Update link, dropdown-menu-nav, and popover to use a11y-label (#675) DropdownMenuNav: Add pharos-elevation-level-3 token (#670) chore(deps-dev): bump vite from 4.3.9 to 4.5.2 (#672) chore: version packages (#667) Update deprecated a11y attributes in button component (#666) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
The React Storybook is failing to build because when Storybook attempts to build, it looks for a Babel configuration, and for story files it's ascending and finding the root
babel.config.jsfile and using only its configuration. Namely, this doesn't include the React preset, and the build fails to understand JSX syntax as a result.How does this change work?
Storybook offers a
babelfunction for manipulating the Babel configuration as a preferred approach, so this change moves the desired configuration to the Storybook config and deletes the root Babel config file, which was added mainly to appease the build earlier on.Additional context