You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
daneah
changed the title
fix(button): fix styling of buttons with on-background within Vue3 apps
Button: fix styling of buttons with on-background within Vue3 apps
Aug 18, 2022
This is only one of a few components that have an on-background attribute, by the looks of it. I would suggest we can eventually merge this pull request without changing those other components, but we might want to broaden #307 to all relevant components and remove Fixes #307 from this PR so that it doesn't get erroneously closed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
michael-iden
requested review from
chrisjbrown,
SMQuazi and
maddy531
and removed request for
a team
daneah
changed the title
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Partially addresses #307
How does this change work?
Changes the
on-backgroundtois-on-backgroundAdditional context
Yalc'd this change over the the Vue3 app and confirmed the button displays correctly when prefixed with
is-