Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore address/credentialId from storage #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

frankudoags
Copy link

@frankudoags frankudoags commented Dec 20, 2024

This pull request adds address and credentialId to the state, and modifies the create and load provider functions to return the address and credentialId for caching, and ensures that the new properties are correctly propagated through the provider.

So that on subsequent calls of 'experimental_connect', we pass in persisted address and credentialId to optimistically connect in a single prompt removing the need for the extra WebAuthn prompt.

This pull request includes several changes to the Porto and accountDelegation modules to add support for handling address and credentialId in the state. The most important changes include updating the state structure, modifying the create and load functions, and ensuring the new properties are correctly propagated through the provider.

Closes (#14)

Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: 79ef232

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oddworld-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 11:52pm
porto-wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 11:52pm

Copy link

vercel bot commented Dec 20, 2024

@frankudoags is attempting to deploy a commit to the Ithaca Team on Vercel.

A member of the Team first needs to authorize it.

@frankudoags
Copy link
Author

@tmm kindly review. Would also like to hear your thoughts on how to address the last todo:

Handle errors if address and/or credentialId are invalid (don't match, signer doesn't have access, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant