Fix possibly cuttoff cli errors in tree views #4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
reviewed
Aug 16, 2023
mattseddon
reviewed
Aug 16, 2023
julieg18
commented
Aug 16, 2023
| @@ -61,6 +61,9 @@ export const getCliErrorTreeItem = ( | |||
| command: RegisteredCommands.EXTENSION_SHOW_OUTPUT, | |||
| title: 'Show DVC Output' | |||
| } | |||
|
|
|||
| treeItem.label = label | |||
There was a problem hiding this comment.
I think the issue has something to do with the fact that we are creating a uri with the error message in the tree item which expects a file path 🤔
julieg18
commented
Aug 17, 2023
| @@ -406,12 +407,16 @@ describe('RepositoriesTree', () => { | |||
|
|
|||
| expect(mockedTreeItem).toHaveBeenCalledTimes(1) | |||
| expect(treeItem).toStrictEqual({ | |||
| ...mockedItem, | |||
There was a problem hiding this comment.
I added tests for each tree that uses the cliError tree item and adjusted the check to not use mockedItem so we could confirm that label is or is not there.
julieg18
commented
Aug 17, 2023
mattseddon
approved these changes
Aug 17, 2023
|
Code Climate has analyzed commit 6c0c00b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main
PR
Fixes #4519