Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot actions button showing on sticky ribbon #4461

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Aug 9, 2023

main

Screen.Recording.2023-08-09.at.4.43.33.PM.mov

PR

Screen.Recording.2023-08-09.at.4.42.02.PM.mov

@julieg18 julieg18 self-assigned this Aug 9, 2023
@julieg18 julieg18 added the bug Something isn't working label Aug 9, 2023
@julieg18 julieg18 changed the title Fix plot actions showing on sticky ribbon Fix plot actions button showing on sticky ribbon Aug 9, 2023
@@ -59,7 +59,7 @@ $gap: 20px;
}

.plotActions {
z-index: 500;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This button shouldn't need such a high z-index.

@julieg18 julieg18 marked this pull request as ready for review August 9, 2023 21:45
@codeclimate
Copy link

codeclimate bot commented Aug 9, 2023

Code Climate has analyzed commit 1d44e59 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 4397975 into main Aug 9, 2023
3 checks passed
@mattseddon mattseddon deleted the fix-plot-ribbon-tooltip-z-index branch August 9, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants