Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude untracked dvc.yaml and dvc.lock files from the DVC SCM tree #4446

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Aug 8, 2023

Noticed this minor issue when producing this demo. We should not show dvc.yaml / dvc.lock files as untracked in the DVC SCM tree as we do not want users to add/track them to/with DVC.

Before

Screenshot 2023-08-08 at 4 18 23 pm

After

Screenshot 2023-08-08 at 4 18 03 pm

@mattseddon mattseddon added the bug Something isn't working label Aug 8, 2023
@mattseddon mattseddon self-assigned this Aug 8, 2023
@mattseddon mattseddon marked this pull request as ready for review August 8, 2023 06:21
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mattseddon mattseddon enabled auto-merge (squash) August 8, 2023 19:57
@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit f35ffca and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit b7a6c51 into main Aug 8, 2023
3 checks passed
@mattseddon mattseddon deleted the exclude-dvc-from-scm branch August 8, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants