Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup on fixing broken plots on first exp run #4425

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Aug 4, 2023

  • reduce array looping
  • add regression test

Followup to #4412

@julieg18 julieg18 self-assigned this Aug 4, 2023
@julieg18 julieg18 marked this pull request as ready for review August 4, 2023 22:07
Copy link
Member

@mattseddon mattseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

extension/src/plots/paths/collect.ts Outdated Show resolved Hide resolved
extension/src/plots/paths/collect.test.ts Outdated Show resolved Hide resolved
@julieg18 julieg18 enabled auto-merge (squash) August 8, 2023 17:27
@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit 9d7ee55 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit c86ee8a into main Aug 8, 2023
3 checks passed
@julieg18 julieg18 deleted the broken-plots-on-first-run-followup branch August 8, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants