Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action menu button to zoomable plots #4398

Merged
merged 7 commits into from
Aug 9, 2023
Merged

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Aug 1, 2023

Demo

Screen.Recording.2023-08-04.at.6.35.46.PM.mov

Part of #4246

@julieg18 julieg18 added the product PR that affects product label Aug 1, 2023
@julieg18 julieg18 self-assigned this Aug 1, 2023
@julieg18 julieg18 changed the title Add action button to zoomable plots Add action menu button to zoomable plots Aug 1, 2023
@@ -58,6 +58,33 @@ $gap: 20px;
}
}

.plotActions {
z-index: 500;
width: 25px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I aimed for a size that looked "ok" across the different plot sizes since it's easier than adjust the sizing based off the one of the multiple plots size variations.

webview/src/plots/components/App.test.tsx Outdated Show resolved Hide resolved
@julieg18 julieg18 marked this pull request as ready for review August 8, 2023 20:29
webview/src/plots/components/App.test.tsx Outdated Show resolved Hide resolved
webview/src/plots/components/App.test.tsx Outdated Show resolved Hide resolved
@mattseddon
Copy link
Member

Storybook snapshots are unhappy:

image

@julieg18
Copy link
Contributor Author

julieg18 commented Aug 9, 2023

Storybook snapshots are unhappy:

image

@mattseddon, are you referring to the fact that there are changes that must be accepted in almost every plot story? Or is there something broken in the stories that I'm missing?

@codeclimate
Copy link

codeclimate bot commented Aug 9, 2023

Code Climate has analyzed commit a906536 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 enabled auto-merge (squash) August 9, 2023 13:20
@julieg18 julieg18 merged commit 6151b0f into main Aug 9, 2023
3 checks passed
@julieg18 julieg18 deleted the show-actions-zoomable-plots branch August 9, 2023 13:25
@mattseddon
Copy link
Member

Storybook snapshots are unhappy:
image

@mattseddon, are you referring to the fact that there are changes that must be accepted in almost every plot story? Or is there something broken in the stories that I'm missing?

image

Does that overlap reflect how the button looks in the app?

@julieg18
Copy link
Contributor Author

julieg18 commented Aug 9, 2023

Does that overlap reflect how the button looks in the app?

Yes, it happens occasionally depending on the plot's contents or size:

image

The button has partial opacity so it's see-through. I didn't see a problem with it, but if you think it looks odd, we could possibly increase the padding of the plot container 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants