-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action menu button to zoomable plots #4398
Conversation
@@ -58,6 +58,33 @@ $gap: 20px; | |||
} | |||
} | |||
|
|||
.plotActions { | |||
z-index: 500; | |||
width: 25px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I aimed for a size that looked "ok" across the different plot sizes since it's easier than adjust the sizing based off the one of the multiple plots size variations.
@mattseddon, are you referring to the fact that there are changes that must be accepted in almost every plot story? Or is there something broken in the stories that I'm missing? |
Code Climate has analyzed commit a906536 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
Does that overlap reflect how the button looks in the app? |
Demo
Screen.Recording.2023-08-04.at.6.35.46.PM.mov
Part of #4246