Add viewable cli process class #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
add-viewable-process
branch
from
f053636 to
0429299
Compare
mattseddon
commented
Feb 27, 2023
| @@ -62,7 +62,12 @@ const sanitizeProperties = ( | |||
| if (value === undefined || value === null) { | |||
| continue | |||
| } | |||
| sanitizeProperty(eventName as string, sanitizedProperties, key, value) | |||
There was a problem hiding this comment.
[F] Not really sure why removing EventName.EXPERIMENTS_RUNNER_COMPLETED caused eslint to freak out here.
mattseddon
commented
Feb 27, 2023
|
|
||
| if (!killed && exitCode && stderr) { | ||
| return sendErrorTelemetryEvent( | ||
| EventName.EXPERIMENTS_RUNNER_COMPLETED, |
There was a problem hiding this comment.
[F] This event has been removed. We don't do this for any other processes that we start.
Merged
mattseddon
commented
Feb 27, 2023
This was referenced Feb 27, 2023
julieg18
approved these changes
Feb 27, 2023
sroy3
approved these changes
Feb 27, 2023
mattseddon
force-pushed
the
group-process
branch
from
9bcbeaa to
c758777
Compare
mattseddon
force-pushed
the
add-viewable-process
branch
from
cc067d6 to
86d6d7c
Compare
|
Code Climate has analyzed commit 86d6d7c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (0.0% change). View more on Code Climate. |
|
Related to #3178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/5
main<- #3356 <- this <- #3359 <- #3361 <- #3362This PR adds a
ViewableCliProcessclass which groups together a process with a pseudoterminal instance. This will be used for things like showing logs for experiments running the queue and long-running processes like pull under certain circumstances.