Add authorize step to both PR workflows #2644
Conversation
|
@0x2b3bfa0 hey, as an expert in this, could you please review and see that we are not missing anything and/or there are better ways to organize it now (run tests for external contributions after an approval). |
|
@mattseddon wrote me a Slack direct message a dozen hours ago asking the same, hence e4e23aa 👍🏼 See also |
|
@0x2b3bfa0 shouldn't the checks be run when I open a PR? |
Because the checks are run in the context of the base branch authorize is not available. See #2645 for when the checks do get run. Will need to merge this in two parts. With |
This seems like a bug in The problem is here: The line needs to be extended to include |
|
Raised paambaati/codeclimate-action#627. This is blocked until that gets resolved. |
mattseddon
added
the
blocked
|
It's hacky, but you could use an |
|
E.g. - uses: paambaati/[email protected]
env:
CC_TEST_REPORTER_ID: ${{secrets.CC_TEST_REPORTER_ID}}
GITHUB_EVENT_NAME: ${{ github.event_name == 'pull_request_target' && 'pull_request' || github.event_name }}
with:
coverageCommand: xvfb-run -a yarn run cover
coverageLocations: ${{github.workspace}}/coverage/lcov.info:lcov |
mattseddon
force-pushed
the
add-authorize-to-pr-workflows
branch
2 times, most recently
from
31c513a to
0af92c1
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
.github/workflows/fun.ts
Outdated
| @@ -0,0 +1,834 @@ | |||
| export const data = { | |||
There was a problem hiding this comment.
File fun.ts has 834 lines of code (exceeds 300 allowed). Consider refactoring.
.github/workflows/fun.ts
Outdated
| ], | ||
| author_association: 'COLLABORATOR', | ||
| auto_merge: null, | ||
| base: { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
.github/workflows/fun.ts
Outdated
| deletions: 2, | ||
| diff_url: 'https://github.com/iterative/vscode-dvc/pull/2645.diff', | ||
| draft: true, | ||
| head: { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
mattseddon
force-pushed
the
add-authorize-to-pr-workflows
branch
3 times, most recently
from
9a2d16c to
e900467
Compare
It doesn't seem like overriding the environment variables like this has any effect on the action 😞. |
|
Code Climate has analyzed commit a217a20 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
mattseddon
force-pushed
the
add-authorize-to-pr-workflows
branch
from
ac9df7a to
433b9a5
Compare
More information: iterative/cml#574 (comment)
Internal
External