Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kubernetes arbitrary node selector #747

Merged
merged 7 commits into from
May 3, 2023
Merged

Add support for Kubernetes arbitrary node selector #747

merged 7 commits into from
May 3, 2023

Conversation

ludelafo
Copy link
Contributor

@ludelafo ludelafo commented Apr 4, 2023

This PR implements the Kubernetes arbitrary node selector described in issue iterative/cml#1365.

This is a work in progress and my first experience with Golang and Terraform provider development, I'm open to improvements.

Related PRs:

@ludelafo ludelafo changed the title Add support for Kubernetes arbitrary node selector in Terraform provider Add support for Kubernetes arbitrary node selector Apr 4, 2023
@ludelafo ludelafo marked this pull request as draft April 4, 2023 08:29
@ludelafo ludelafo marked this pull request as ready for review April 6, 2023 08:17
iterative/resource_machine.go Outdated Show resolved Hide resolved
@dacbd dacbd added resource-runner iterative_runner TF resource resource-machine iterative_machine TF resource cloud-k8s Kubernetes labels Apr 7, 2023
@ludelafo ludelafo marked this pull request as draft April 12, 2023 09:53
@ludelafo ludelafo marked this pull request as ready for review April 12, 2023 16:33
task/k8s/resources/resource_job.go Outdated Show resolved Hide resolved
@dacbd dacbd requested a review from 0x2b3bfa0 May 2, 2023 22:10
@dacbd dacbd merged commit 705679f into iterative:main May 3, 2023
@ludelafo ludelafo deleted the add-support-for-kubernetes-arbitrary-node-selector branch June 5, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-k8s Kubernetes resource-machine iterative_machine TF resource resource-runner iterative_runner TF resource
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants