Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty buckets during Delete() #420

Merged

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Mar 3, 2022

Would fix #388 az consistency issue and adds debug output to diagnose further status inconsistencies. Additionally, simplifies all the bucket emptying logic by using rclone instead of provider–specific code.

Side note: these changes are also a small step towards #299.

@0x2b3bfa0 0x2b3bfa0 self-assigned this Mar 3, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 3, 2022 15:12 Inactive
@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working cloud-az Microsoft Azure cloud-common Applies to every cloud vendor resource-task iterative_task TF resource technical-debt Refactoring, linting & tidying labels Mar 3, 2022
@0x2b3bfa0 0x2b3bfa0 force-pushed the 388-`task`-status-is-confusing-and-not-working-properly branch from befe5ac to 125440f Compare March 3, 2022 15:31
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 3, 2022 15:31 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 3, 2022 15:32 Inactive
@0x2b3bfa0 0x2b3bfa0 force-pushed the 388-`task`-status-is-confusing-and-not-working-properly branch from 876f569 to 06f8c4a Compare March 3, 2022 15:35
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 3, 2022 15:39 Inactive
@DavidGOrtega
Copy link
Contributor

This is expected to take seconds rather than minutes, though. 🙈

Weird. For me takes close to 10min almost constantly. I have to sync 20 files of 1KB each, but aside that...

@0x2b3bfa0
Copy link
Member Author

🥶 Only on Azure?

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 13:44 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 13:44 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 13:44 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 13:44 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 14:13 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 14:13 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 14:13 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 14:13 Inactive
@DavidGOrtega
Copy link
Contributor

@0x2b3bfa0 K8 test is failing

@0x2b3bfa0
Copy link
Member Author

❄️ Flaky, not related to this pull request. willfix

Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Tested it does not totally fix #388 but the biggest issue is working right now perfectly or I was not able to reproduce it 🎉

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 16:02 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 16:02 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 16:02 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 16:02 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 7, 2022 16:02 Inactive
@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Mar 7, 2022

@DavidGOrtega, please always run terraform with DEBUG level logs, and post them if you ever hit again the running=0 but actually running condition.

@0x2b3bfa0
Copy link
Member Author

@DavidGOrtega: all green in 3, 2, 1, ... 🚀

@DavidGOrtega DavidGOrtega merged commit b47f801 into master Mar 7, 2022
@DavidGOrtega DavidGOrtega deleted the 388-`task`-status-is-confusing-and-not-working-properly branch March 7, 2022 16:52
0x2b3bfa0 added a commit that referenced this pull request Mar 23, 2022
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Mar 23, 2022
casperdcl pushed a commit that referenced this pull request Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cloud-az Microsoft Azure cloud-common Applies to every cloud vendor resource-task iterative_task TF resource technical-debt Refactoring, linting & tidying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task status is confusing and not working properly
3 participants