Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Add new DVC extra #633

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Add new DVC extra #633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
"webdav",
"webhdfs",
"webhdfs_kerberos",
"lint",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? We usually move these things around without a guarantee that they will always work or be available (other than remote related extras).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to enable pip install mlem[dvc-s3] and ones like that. We have a test that checks we didn't miss anything, that's why we need to add keep it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I think we should've added it here instead

mlem/tests/test_setup.py

Line 18 in d2100ac

if e not in {"all", "dev", "terraform", "tests", "testing"}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing that in #634

]:
extras[f"dvc-{e}"] = [f"dvc[{e}]~=2.0"]

Expand Down