This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
serve fastapi: expose /metrics endpoint for Prometheus
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguschin
added
serve
aguschin
changed the title
/metrics endpoint for Prometheusserve fastapi: expose /metrics endpoint for Prometheus
aguschin
added a commit
that referenced
this pull request
Mar 25, 2023
…ometheus (#629) did this in spare time instead of #591 using https://github.com/trallnag/prometheus-fastapi-instrumentator these middlewares can be enabled via CLI if referenced by their `type` ClassVar: ``` $ mlem --tb serve fastapi --model ../emoji/lyrics2emoji --middlewares.0 prometheus_fastapi ``` --------- Co-authored-by: mike0sv <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to expose
/metricsendpoint to be scraped by Prometheus, when a model is served with FastAPI.related to #429 and #589
The result looks like
