-
Notifications
You must be signed in to change notification settings - Fork 44
run heroku tests on detection from title OR schedule #433
Conversation
3260ecc
to
e7ae2c9
Compare
e7ae2c9
to
c7c4bb5
Compare
c7c4bb5
to
3be042a
Compare
Codecov ReportBase: 87.81% // Head: 84.81% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 87.81% 84.81% -3.00%
==========================================
Files 96 96
Lines 7909 7804 -105
==========================================
- Hits 6945 6619 -326
- Misses 964 1185 +221
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Trying to understand how this should work. Will it require commit hash when one tries to run the tests manually? Also, can I test it out in this branch before merging to main
?
UPD: I just did a commit assuming it will ask me for input (commit hash), but looks like this works differently.
@madhur-tandon could use your help here to understand this ^ :) |
4d6b8a4
to
add2d68
Compare
Earlier, I was using something known as a |
Looking good! Thanks @madhur-tandon! I remember we had a discussion about doing the same for k8s/sagemaker. Don't remember the resolution. Should we do this for them also? |
K8s test are self contained, won't be necessary. |
how much time do they take? Speeding up CI would be a good thing also. |
The point of this PR was not to speed up CI, it was to control flaky behaviour of heroku so we don't get unnecessary failures. |
No description provided.