Get rid of mlem dir #395
Get rid of mlem dir #395
Conversation
Codecov ReportBase: 87.62% // Head: 87.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release/0.3.0 #395 +/- ##
=================================================
- Coverage 87.62% 87.60% -0.02%
=================================================
Files 94 94
Lines 7847 7714 -133
=================================================
- Hits 6876 6758 -118
+ Misses 971 956 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| """Creates .mlem directory in `path`""" | ||
| path = posixpath.join(path, MLEM_DIR) | ||
| """Creates mlem config in `path`""" | ||
| path = posixpath.join(path, MLEM_CONFIG_FILE_NAME) |
There was a problem hiding this comment.
I know the file is called .mlem.yaml. But for GTO it's .gto. Should we rename it to .gto.yaml in GTO, or should we rename .mlem.yaml to .mlem? We shouldn't confuse users with different approaches. Did we had same files in other tools maybe? cc @shcheklein
There was a problem hiding this comment.
Also if users have .mlem dir now, it's not possible to create .mlem file. So renaming config file will force them to move everything outside of .mlem dir and change their workflows maybe.
There was a problem hiding this comment.
@mike0sv if everything else is good, let's merge this so we won't get a PR queue again? And then discuss it separately.
There was a problem hiding this comment.
my 2 cents - if the file is indeed a yaml, gto.yaml > [something.]gto
extensions are for formats :)
as long as gto doesn't invent a new file format/structure but respects yaml, that's the least surprising thing to do
There was a problem hiding this comment.
Ok, then it's decided I guess. Let's keep it here, and I'll update it in GTO as well some time later.
closes #381