Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

replace _ExternalRef logic with persistent_id #365

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Jul 29, 2022

also
closes #364

@mike0sv mike0sv requested a review from a team July 29, 2022 21:29
@mike0sv mike0sv self-assigned this Jul 29, 2022
@mike0sv mike0sv temporarily deployed to internal July 29, 2022 21:29 Inactive
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #365 (00f411e) into main (95d521b) will increase coverage by 5.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   84.37%   89.49%   +5.12%     
==========================================
  Files          81       81              
  Lines        6297     6275      -22     
==========================================
+ Hits         5313     5616     +303     
+ Misses        984      659     -325     
Impacted Files Coverage Δ
mlem/core/objects.py 91.42% <ø> (+4.93%) ⬆️
mlem/contrib/callable.py 98.26% <100.00%> (-0.19%) ⬇️
mlem/core/metadata.py 95.91% <100.00%> (+2.93%) ⬆️
mlem/contrib/dvc.py 60.29% <0.00%> (-0.90%) ⬇️
mlem/utils/root.py 91.66% <0.00%> (+0.23%) ⬆️
mlem/core/requirements.py 95.05% <0.00%> (+0.38%) ⬆️
mlem/core/meta_io.py 94.11% <0.00%> (+0.53%) ⬆️
mlem/utils/module.py 90.11% <0.00%> (+0.76%) ⬆️
mlem/api/commands.py 88.88% <0.00%> (+2.22%) ⬆️
mlem/contrib/sklearn.py 81.25% <0.00%> (+3.12%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aguschin aguschin temporarily deployed to internal August 8, 2022 09:29 Inactive
@aguschin aguschin temporarily deployed to internal August 8, 2022 09:42 Inactive
@aguschin aguschin merged commit ee994a0 into main Aug 8, 2022
@aguschin aguschin deleted the fix/pickling-pers-id branch August 8, 2022 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

mlem.api.load: Optional types break model loading
2 participants