This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
Support combining batched prediction results on DatasetType #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated the branch, now auth issues are gone. But there are some others I didn't investigate. @terryyylim do you mind taking a look? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A bug was introduced in #221, where approach to combining prediction results incorrectly assumed type to be numpy array. This PR utilizes
DatasetAnalyzerto first determine the type of the results prior to combining them, since the same model can output different data types.Modifications
mlem/api/commands.py- Interpret data type prior to combining prediction resultsmlem/contrib/numpy.py- Add support for combining batch reading prediction results for nd.arrayWhich issue(s) this PR fixes:
Fixes #257