You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
Hey @aguschin@mike0sv , I just noticed this issue I introduced in my previous PR, sorry about that 🙏🏻 I thought through more deeply, and I think this merging of results should be dependent on different model types. What do y'all think about introducing a method on ModelType class, eg. merge_results, that take an array of a certain type and combine the results accordingly based on their types (e.g numpy array in the case of sklearn predict, predict_proba methods). In this case, commands.py will not need to know model-specific details.
#221 introduced numpy dependency in
api.py
: https://github.com/iterative/mlem/blob/main/mlem/api/commands.py#L7We either need to remove it, or we need to add
numpy
to install_requires insetup.py
.The text was updated successfully, but these errors were encountered: