This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Fix GitHub button #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gatsby Cloud Build Reportmlem.ai 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
|
Nice. The actual issue with the Github button is that it opens 404 pages though. The links produced are all wrong. Examples: https://mlem.ai/doc/user-guide, https://mlem.ai/doc/use-cases/dvc |
|
Ah, good to know, the function that makes the links must have been originally set back when the main branch was |
julieg18
reviewed
May 25, 2022
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo (dvc.org, mlem.ai before, mlem.ai after)
github-button-demo.mp4
This PR fixes the breakpoint issues for the docs "Edit on GitHub" buttons, shifting around the media queries to reflect the more mobile-first approach of mlem.ai as well as adding a new 1200px
--xl-scrbreakpoint that reflects the inline queries that dvc.org uses to switch the content and sidebar versions of these buttons.Relates to #63
Extends #72 because it uses the same shadowed
RightPanelstylesheet that that PR introduces.