-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
Gatsby Cloud Build Reportmlem.ai 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 56s PerformanceLighthouse report
|
Please assign me, @jorgeorpinel, I think it will be more consistent :) |
Should I go ahead and review this or should I wait until you complete other items? @jorgeorpinel |
Thanks and please go ahead @aguschin .
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match #79 (comment) (committing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @jorgeorpinel! Should we merge this or you want to complete your items before that?
@@ -58,8 +58,8 @@ command. | |||
'pandas']. Defaults to auto-infer. | |||
- `copy_data` (optional) - Whether to create a copy of file in target location | |||
or just link existing file. Defaults to True. | |||
- `external` (optional) - Save result not in `.mlem`, but directly in repo | |||
- `index` (optional) - Whether to index output in `.mlem` directory | |||
- `external` (optional) - Save result directly in repo (not in `.mlem/`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `external` (optional) - Save result directly in repo (not in `.mlem/`) | |
- `external` (optional) - Save result directly to `target` (not in `.mlem/`) |
This is more correct, since with external=True
it doesn't take into account the MLEM project at all. Also, it's not repo, it's project now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you should've felt free to commit your fixes too 🙂 but anyway, we'll get to it... ⌛
which can then be used in future operations such as `mlem apply`. | ||
Use `import` on an existing datasets or model files (or directories) to generate | ||
the necessary `.mlem` metafiles for them. This is useful to quickly make | ||
existing datasets and model files compatible with MLEM, which can then be used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
existing datasets and model files compatible with MLEM, which can then be used | |
existing datasets and model files compatible with MLEM, which then can be used |
?
containing the model binary and `.mlem` file containing metadata. Let's take a | ||
look at it: | ||
The model was saved along with some metadata about it: `rf` containing the model | ||
binary and a `.mlem` metafile containing information about it. Let's take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
binary and a `.mlem` metafile containing information about it. Let's take a look | |
binary and a `rf.mlem` metafile containing information about it. Let's take a look |
@@ -49,7 +49,7 @@ $ mlem config set default_storage.type dvc | |||
``` | |||
|
|||
Also, let’s add `.mlem` files to `.dvcignore` so that metafiles are ignored by | |||
DVC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated due to #79
@jorgeorpinel, I've merged this PR. Please feel free to continue the discussion/improvements once you have some time! |
Thanks! I'm catching up 😬 |
Continues misc. quality improvements from #43 (comment)
Main updates:
.mlem/
vs..mlem