Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ls-url and list-url commands #89

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Add ls-url and list-url commands #89

merged 2 commits into from
Oct 7, 2022

Conversation

rogermparent
Copy link
Contributor

No description provided.

@rlamy
Copy link

rlamy commented Oct 7, 2022

LGTM. Is there a way to see what this does in conjunction with iterative/dvc.org#3996?

@rogermparent
Copy link
Contributor Author

LGTM. Is there a way to see what this does in conjunction with iterative/dvc.org#3996?

There is locally, though it's a little obtuse. I'll set it up on my end, take some screenshots, and describe how to replicate.

@dberenbaum
Copy link
Contributor

Thanks @rogermparent! That might be overkill. Is there any downside to merging this? Then I assume it should be easy to see the impact in iterative/dvc.org#3996?

@rogermparent
Copy link
Contributor Author

rogermparent commented Oct 7, 2022

The standard procedure is to merge this, ship the theme, then Renovate will (or at least should) make an update PR that gets a deploy preview where we can see this PR's effect on dvc.org main. To see this PR's on that dvc.org PR, we'd have to merge the update into dvc.org and check that PR's deploy preview after it merges main.

It should only take a minute or two on my end to at least confirm with a screenshot, then I'll merge and do the rest of the standard stuff.

@rogermparent
Copy link
Contributor Author

Ah! Glad I tried it. I think I forgot to put list-url higher up to get it to take precedence over list.
image

@rogermparent
Copy link
Contributor Author

rogermparent commented Oct 7, 2022

image
Fixed! 🎉 Thanks for the approvals!

@rogermparent rogermparent temporarily deployed to gatsby-theme-add-ls-url-h0asyo October 7, 2022 15:50 Inactive
@rogermparent rogermparent enabled auto-merge (squash) October 7, 2022 15:50
@rogermparent rogermparent merged commit 192d717 into main Oct 7, 2022
@rogermparent rogermparent deleted the add-ls-url branch October 7, 2022 15:51
@dberenbaum
Copy link
Contributor

Thanks @rogermparent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants