Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): set next/prev properly on deep nested tree #201

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

shcheklein
Copy link
Member

Fixes #200

The issue was in not going deep in enough in children hierarchy to set the "previous" item pointer. It was setting it only to the next level of children:

- first item
  - nested item <--- it would always pick this as a previous while processing the `second item` below
     - nested nested item
        - - nested nested nested item <--- we should go down the tree to the bottom to find the deepest child
- second item

@shcheklein shcheklein added 🐛 type: bug Something isn't working. p1-important A: website Website development labels May 5, 2023
@shcheklein shcheklein self-assigned this May 5, 2023
@shcheklein shcheklein requested a review from a team as a code owner May 5, 2023 02:22
@yathomasi yathomasi temporarily deployed to gatsby-theme-fix-200-yeo94d3gb May 5, 2023 02:24 Inactive
@shcheklein shcheklein temporarily deployed to gatsby-theme-fix-200-yeo94d3gb May 5, 2023 02:27 Inactive
Copy link
Contributor

@yathomasi yathomasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shcheklein. Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Website development p1-important 🐛 type: bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next button doesn't work as expected
2 participants