Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much needed housekeeping for websites #199

Merged
merged 9 commits into from
May 5, 2023
Merged

Much needed housekeeping for websites #199

merged 9 commits into from
May 5, 2023

Conversation

yathomasi
Copy link
Contributor

Note: I haven't tested this with GHA but only with dry run so it might fail but it should be safe to try out with pre-release without side-effect.

@@ -4,7 +4,6 @@ const {
} = require('../gatsby-theme-iterative/package.json')

module.exports = {
trailingSlash: 'never',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it always w/o slash please. Just to confirm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I see that we moved it.

@shcheklein
Copy link
Member

Good stuff, thanks @yathomasi for taking an effort there.

@yathomasi yathomasi self-assigned this May 2, 2023
@yathomasi yathomasi marked this pull request as ready for review May 5, 2023 04:46
@yathomasi yathomasi requested a review from a team as a code owner May 5, 2023 04:46
@yathomasi yathomasi temporarily deployed to gatsby-theme-housekeepi-qnpos6 May 5, 2023 04:47 Inactive
@yathomasi yathomasi merged commit 4cae01b into main May 5, 2023
@yathomasi yathomasi deleted the housekeeping branch May 5, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants