Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mlem get started #109
Add mlem get started #109
Changes from 1 commit
7993131
e5bd46c
234576f
94424a0
ed79b4f
e75c3da
daaea8f
0571605
0bc373e
59a1a2d
64e20d1
3dd0bc6
50151a5
21e14ce
0333049
e34e6ae
51f32c1
7ce9d77
ca0ae1d
0bd97e2
20582ea
8b33bd3
e79b2ec
3c4ecd8
5cbdeb8
0b3fb35
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don it similar to DVC get-started you need to bundle this code and share from S3 so that people could curl or wget it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not get it from raw.github.com?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raw.github.com works as well, I don't see any particular problems with that .. I would bundle though everything as a single tar (or may github has a way to download revisions as a tar with curl, I don't know)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/iterative/example-mlem-get-started/archive/refs/tags/5-switch-to-dvc.tar.gz for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it contains some extra files that are not needed initially though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it contains whole repo, yes. But I don't see any point of maintaining them separately, since they are very small and easy and also will be available in the docs themselves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not about the size, it's about the workflow. In the dvc.org get started you would have a command:
https://dvc.org/doc/start/data-pipelines#expand-to-download-example-code
including any extra files there would confuse and ruin the flow of the document.
so, your call here - if you want something similar to DVC then consider creating a clean code package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will consider this, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking second time - I remember now why I didn't use GH (most likely) - I wanted to keep the command as short and nice as possible
wget https://code.dvc.org/get-started/code.zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not very common for DVC to track each independently (esp dataset) - is it intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are .mlem files in this dir. Can we do something like
echo *.mlem > .dvcignore && dvc add data
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the correct pattern was found and it is
/**/?*.mlem
. Btw, does dvcignore support ! negation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not seem to work, since we cant
dvc add .mlem/dataset/
since we lose.mlem
files, even though they ignored. So going withdvc add .mlem/dataset/*.csv
. Would be great to have some way to do "add everything except dvc-ignored"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it does support it
it should be working, otherwise it's a bug to my mind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to make an exception for
.mlem
dir in a root, but this is what I've gotThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q - why do you need an exception like this? (curious)
does the same combination work for gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goal is to exclude all
*.mlem
files, but not.mlem
dir in repo root. But simple/**/*.mlem
adds.mlem
dir to ignore list. With git this exclusion works works