Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: support strings #9387

Merged

Conversation

paulourbano
Copy link
Contributor

@paulourbano paulourbano commented May 1, 2023

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (ac3eef4) 91.61% compared to head (55cae68) 91.60%.

❗ Current head 55cae68 differs from pull request most recent head 8f1019b. Consider uploading reports for the commit 8f1019b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9387      +/-   ##
==========================================
- Coverage   91.61%   91.60%   -0.01%     
==========================================
  Files         487      487              
  Lines       37778    37778              
  Branches     5436     5436              
==========================================
- Hits        34610    34608       -2     
- Misses       2612     2613       +1     
- Partials      556      557       +1     
Impacted Files Coverage Ξ”
dvc/utils/diff.py 82.35% <ΓΈ> (ΓΈ)
dvc/repo/metrics/show.py 96.51% <100.00%> (-2.33%) ⬇️
tests/func/metrics/test_diff.py 100.00% <100.00%> (ΓΈ)
tests/func/test_lockfile.py 100.00% <100.00%> (ΓΈ)

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo added A: metrics Related to dvc metrics enhancement Enhances DVC labels May 2, 2023
@daavoo daavoo self-requested a review May 2, 2023 07:15
Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @paulourbano !

Could you drop the diff change and update the tests accordingly?

dvc/utils/diff.py Outdated Show resolved Hide resolved
@daavoo daavoo linked an issue May 2, 2023 that may be closed by this pull request
@paulourbano
Copy link
Contributor Author

Thanks for the contribution @paulourbano !

Could you drop the diff change and update the tests accordingly?

Sure, I will do the changes.
Thanks!

@paulourbano paulourbano requested a review from daavoo May 2, 2023 16:38
@paulourbano
Copy link
Contributor Author

paulourbano commented May 2, 2023

Test failures (tests/func/test_lockfile.py::test_cmd_changes_other_orders_are_preserved, among others) are also showing in main with latest commit 1f03c40. Root cause seems not to be related to this PR.

@daavoo daavoo enabled auto-merge (squash) May 4, 2023 08:37
@daavoo daavoo force-pushed the issue/7960-support-strings-in-metrics branch from 27687ec to 79a49b3 Compare May 4, 2023 08:37
auto-merge was automatically disabled May 5, 2023 17:52

Head branch was pushed to by a user without write access

@efiop efiop changed the title Issue/7960 support strings in metrics metrics: support strings May 5, 2023
@daavoo daavoo force-pushed the issue/7960-support-strings-in-metrics branch from 55cae68 to 8f1019b Compare May 5, 2023 19:49
@daavoo daavoo enabled auto-merge (rebase) May 5, 2023 19:49
@daavoo daavoo merged commit 8ecc66a into iterative:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: metrics Related to dvc metrics enhancement Enhances DVC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support strings in metrics
2 participants