-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: support strings #9387
metrics: support strings #9387
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9387 +/- ##
==========================================
- Coverage 91.61% 91.60% -0.01%
==========================================
Files 487 487
Lines 37778 37778
Branches 5436 5436
==========================================
- Hits 34610 34608 -2
- Misses 2612 2613 +1
- Partials 556 557 +1
β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @paulourbano !
Could you drop the diff
change and update the tests accordingly?
Sure, I will do the changes. |
Test failures ( |
27687ec
to
79a49b3
Compare
Head branch was pushed to by a user without write access
for more information, see https://pre-commit.ci
55cae68
to
8f1019b
Compare
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. π