dvcfs: implement get_file #9057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2023
Codecov ReportBase: 93.02% // Head: 92.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9057 +/- ##
==========================================
- Coverage 93.02% 92.99% -0.03%
==========================================
Files 457 457
Lines 36813 36827 +14
Branches 5338 5340 +2
==========================================
+ Hits 34244 34246 +2
- Misses 2050 2057 +7
- Partials 519 524 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Currently we use `open`, which is much slower. For example, ``` $ dvc get dvc-bench data/small/dataset ``` goes down from 110sec to 50sec. Discovered as a part of https://github.com/iterative/dvc-bench/issues/419
|
There is a bit more so squeeze out in iterative/dvc-objects#197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use
open, which is much slower. For example,goes down from 110sec to 50sec (which is still too much).
Discovered as a part of #9098