Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import/import-url: try not to delete dvcfile before import/import-url completes #8876

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jan 25, 2023

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Related to #3362.

@skshetry skshetry requested a review from efiop January 25, 2023 06:25
@skshetry skshetry added the enhancement Enhances DVC label Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 93.64% // Head: 93.72% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (51cdc6c) compared to base (61afdca).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8876      +/-   ##
==========================================
+ Coverage   93.64%   93.72%   +0.07%     
==========================================
  Files         453      453              
  Lines       36101    36141      +40     
  Branches     5237     5239       +2     
==========================================
+ Hits        33808    33872      +64     
+ Misses       1787     1761      -26     
- Partials      506      508       +2     
Impacted Files Coverage Δ
dvc/repo/imp_url.py 80.95% <100.00%> (-2.03%) ⬇️
tests/unit/output/test_output.py 100.00% <0.00%> (ø)
tests/unit/stage/test_serialize_pipeline_lock.py 100.00% <0.00%> (ø)
tests/func/test_add.py 98.72% <0.00%> (+0.01%) ⬆️
dvc/stage/__init__.py 94.70% <0.00%> (+0.63%) ⬆️
dvc/stage/serialize.py 94.91% <0.00%> (+2.60%) ⬆️
dvc/output.py 90.26% <0.00%> (+2.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry merged commit bb9a3a0 into main Jan 25, 2023
@skshetry skshetry deleted the do-not-remove-import-url branch January 25, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant