exp run: Use hydra for parsing --set-param.
#8067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
commented
Jul 29, 2022
| [["foo=baz", "goo=bar"], "{foo: baz, goo: bar, lorem: false}"], | ||
| [ | ||
| ["goo.bag=4"], | ||
| "{foo: [bar: 1, baz: 2], goo: {bag: 4}, lorem: false}", | ||
| ], | ||
| [["foo[0]=bar"], "{foo: [bar, baz: 2], goo: {bag: 3}, lorem: false}"], |
There was a problem hiding this comment.
To modify a list, foo[0]=bar must now be passed as foo.0=bar.
daavoo
commented
Jul 29, 2022
Comment on lines
-118
to
-124
| [ | ||
| ["foo[1]=[baz, goo]"], | ||
| "{foo: [bar: 1, [baz, goo]], goo: {bag: 3}, lorem: false}", | ||
| ], |
There was a problem hiding this comment.
Converting a dictionary to a list is not supported by omegaconf.
daavoo
commented
Jul 29, 2022
| @@ -61,6 +51,53 @@ def is_same_type(a, b): | |||
| ) | |||
|
|
|||
|
|
|||
| def to_omegaconf(item): | |||
There was a problem hiding this comment.
All these 4 functions had to be added because we try to preserve comments while modifying the params file.
I don't know if this comment-preserving logic was a user request or how relevant it actually is.
For example, YAML spec says:
Comments are a presentation detail and must not have any effect on the serialization tree or representation graph.
In particular, comments are not associated with a particular node.
If we discard the idea of trying to preserve comments we could remove quite a lot of code
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
dberenbaum
reviewed
Jul 29, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Python support is still pretty buggy but if anything is probably better than before (cc @skshetry) |
daavoo
force-pushed
the
hydra
branch
2 times, most recently
from
7e94025 to
1b186d9
Compare
daavoo
commented
Jul 29, 2022
daavoo
commented
Jul 29, 2022
daavoo
force-pushed
the
hydra
branch
2 times, most recently
from
e988d88 to
90d0457
Compare
daavoo
commented
Aug 1, 2022
daavoo
force-pushed
the
hydra
branch
3 times, most recently
from
24b127f to
5aa2943
Compare
dberenbaum
approved these changes
Aug 3, 2022
pmrowla
reviewed
Aug 4, 2022
daavoo
force-pushed
the
hydra
branch
2 times, most recently
from
2db963e to
d161ff8
Compare
2 tasks
pmrowla
approved these changes
Aug 5, 2022
- Overriding a config value : foo.bar=value - Appending a config value : +foo.bar=value - Appending or overriding a config value : ++foo.bar=value - Removing a config value : ~foo.bar, ~foo.bar=value See https://hydra.cc/docs/advanced/override_grammar/basic/#modifying-the-config-object --- Breaking changes: To modify a list, `foo[0]=bar` must now be passed as `foo.0=bar`. Modifying a nested list inside a dictionary is not supported by omegaconf. --- Closes #4883 Closes #5868 Closes #6129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hydra.cc/docs/advanced/override_grammar/basic/#modifying-the-config-object
💣 Breaking changes:
To modify a list,
foo[0]=barmust now be passed asfoo.0=bar.Converting a dictionary to a list is not supported by omegaconf.
None of the two were documented.
Closes #4883
Closes #5868
Closes #6129
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.