add, import-url: always resolve the output in the local path for --to-remote #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
force-pushed
the
to-remote-output-resolver
branch
from
60ad639 to
b457d98
Compare
2 tasks
skshetry
reviewed
Feb 18, 2021
skshetry
reviewed
Feb 18, 2021
skshetry
reviewed
Feb 18, 2021
| @@ -357,7 +357,7 @@ def resolve_output(inp, out): | |||
| return ret | |||
|
|
|||
|
|
|||
| def resolve_paths(repo, out): | |||
| def resolve_paths(repo, out, always_local=False): | |||
There was a problem hiding this comment.
IIUC, always_local is a high-level concept. Here, it does not convey what it does properly: using the base path as an output name. But, I don't have a good name to suggest either (that is succinct), so I'm fine with it as well. 😄
There was a problem hiding this comment.
I also couldn't think of a better one 🤔
skshetry
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the discussions on #5445, it seemed
--externalis redundantly needed when trying to add an absolute path in the local system without-o. This wasn't the case for remote locations, such ass3://orazure://. So this PR forbids the usage of--externalwithto-remote/to-cacheand normalizes absolute system paths just like other remote providers.