-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdrive: download: stream & add progress #3722
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3722 +/- ##
=======================================
Coverage 90.80% 90.80%
=======================================
Files 158 158
Lines 10582 10582
=======================================
Hits 9609 9609
Misses 973 973 Continue to review full report at Codecov.
|
P.S. @shcheklein I don't think we need to bother about |
@casperdcl yep, that's why I was not that worried about bom in the first place (e.g. performance). |
Also #2865 says
for the file streaming bit... What docs? |
@casperdcl yeah, this one doesn't solve the API streaming. It is the next level of avoiding writing stuff to the disk - |
ah I see |
yes just pushed a final quick update (because of the deferred +11
-21 Pretty sure there's at least one (if not 3) fewer API calls. #2511 would tell. |
also please don't merge until conda-forge/pydrive2-feedstock#10 (which doesn't exist yet) |
ok good to go |
Thank you @casperdcl ! 🙏 |
patch underlyinghttplib2
for gdrive progressAlso consider using something other thanavoid loading the whole file into RAMhttplib2
/pydrive2
(e.g. usehttp.client
directly orrequests
which both support iteration) topydrive>=1.4.11
)ApiRequestError.GetField()
GetContentFile(callback=Tqdm.update_to)