cached params files don't get collected

[dberenbaum]

Bug Report

Description

Top-level params files that are saved to the cache don't get collected in params/exp show.

First reported by @slevang in #7224.

Reproduce

From a fresh Git/DVC repo, add this dvc.yaml:

stages:
  dump_params:
    cmd: 'echo "param: 1" > my_params.yaml'
    outs:
      - my_params.yaml
params:
  - my_params.yaml

Then run this:

$ dvc exp run
$ dvc exp show
 ─────────────────────────────────────────────
  Experiment                 Created    param
 ─────────────────────────────────────────────
  workspace                  -          1
  main                       01:18 PM   -
  └── 5d93ec0 [zinky-sled]   01:25 PM   !
 ─────────────────────────────────────────────

Expected

The experiment row should show 1 instead of ! under the param column.

Environment information

$ dvc doctor
DVC version: 2.57.1
-------------------
Platform: Python 3.10.10 on macOS-13.3.1-arm64-arm-64bit
Subprojects:
        dvc_data = 0.51.0
        dvc_objects = 0.22.0
        dvc_render = 0.5.2
        dvc_task = 0.2.1
        scmrepo = 1.0.3
Supports:
        azure (adlfs = 2023.1.0, knack = 0.10.1, azure-identity = 1.12.0),
        gdrive (pydrive2 = 1.15.3),
        gs (gcsfs = 2022.11.0),
        hdfs (fsspec = 2022.11.0, pyarrow = 11.0.0),
        http (aiohttp = 3.8.4, aiohttp-retry = 2.8.3),
        https (aiohttp = 3.8.4, aiohttp-retry = 2.8.3),
        oss (ossfs = 2021.8.0),
        s3 (s3fs = 2022.11.0, boto3 = 1.24.59),
        ssh (sshfs = 2023.4.1),
        webdav (webdav4 = 0.9.8),
        webdavs (webdav4 = 0.9.8),
        webhdfs (fsspec = 2022.11.0)
Config:
        Global: /Users/dave/Library/Application Support/dvc
        System: /Library/Application Support/dvc
Cache types: reflink, hardlink, symlink
Cache directory: apfs on /dev/disk3s1s1
Caches: local
Remotes: local
Workspace directory: apfs on /dev/disk3s1s1
Repo: dvc, git
Repo.site_cache_dir: /Library/Caches/dvc/repo/6414c2ff59800d13bb7dc40946807396

[dberenbaum]

It's important to be able to track params as outputs. In most cases, they don't need to be cached, but since that's the default behavior for outputs, it will often break when users try it.

[slevang]

@dberenbaum should I expect these changes to work on the Studio side now that this is released, or is there a delay there? When I try this in my dvc.yaml on 3.20.0, the params do show up in dvc params diff or dvc exp show but they don't seem to load into Studio when I push an experiment.

[shcheklein]

@slevang yes, it's not released / fixed on the Studio side. I'll try to update it soon.

[slevang]

That's what I figured, thanks. No rush, just wanted to make sure I wasn't missing something.

[shcheklein]

@slevang I think it should be now released and deployed to Studio. Could you please give it a try when you have time and confirm if everything works fine for you.