Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

top-level params and metrics: support directories #9452

Closed
Tracked by #9722
dberenbaum opened this issue May 15, 2023 · 3 comments · Fixed by #9909
Closed
Tracked by #9722

top-level params and metrics: support directories #9452

dberenbaum opened this issue May 15, 2023 · 3 comments · Fixed by #9909
Assignees
@skshetry
Labels
A: metrics Related to dvc metrics A: params Related to dvc params p2-medium Medium priority, should be done, but less important

Comments

@dberenbaum
Copy link
Collaborator

Top-level params and metrics now support only files, but like plots, it would be helpful to also support directories. See #7224 (comment).
@dberenbaum dberenbaum added A: params Related to dvc params A: metrics Related to dvc metrics labels May 15, 2023
@slevang slevang mentioned this issue May 15, 2023
Open
@dberenbaum dberenbaum mentioned this issue May 15, 2023
Closed
@dberenbaum dberenbaum added the p3-nice-to-have It should be done this or next sprint label May 20, 2023
@daavoo daavoo added p2-medium Medium priority, should be done, but less important and removed p3-nice-to-have It should be done this or next sprint labels Jun 13, 2023
@daavoo
Copy link
Contributor

daavoo commented Jun 13, 2023

I think the metrics directory support also makes sense at the stage level.

This should be a simple thing to implement (unless I am missing something) because the collection already supports directories via the recursive flag (https://dvc.org/doc/command-reference/metrics/show#-R)

@dberenbaum dberenbaum added p1-important Important, aka current backlog of things to do and removed p2-medium Medium priority, should be done, but less important labels Jun 13, 2023
@dberenbaum dberenbaum added this to DVC Jun 13, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DVC Jun 13, 2023
@dberenbaum
Copy link
Collaborator Author

Related to #9478

@dberenbaum
Copy link
Collaborator Author

Looks to be related/duplicate of #2973.

@dberenbaum dberenbaum mentioned this issue Jul 11, 2023
Closed
4 tasks
@dberenbaum dberenbaum mentioned this issue Aug 10, 2023
Closed
@dberenbaum dberenbaum added p2-medium Medium priority, should be done, but less important and removed p1-important Important, aka current backlog of things to do labels Aug 10, 2023
@skshetry skshetry mentioned this issue Sep 4, 2023
Merged
3 tasks
@dberenbaum dberenbaum removed this from DVC Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skshetry skshetry

Labels
A: metrics Related to dvc metrics A: params Related to dvc params p2-medium Medium priority, should be done, but less important
Projects
None yet
Milestone
No milestone
3 participants
@dberenbaum @daavoo @skshetry