Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp: generate random experiment names at start of each experiment #8650

Closed
dberenbaum opened this issue Dec 1, 2022 · 3 comments · Fixed by #8659
Closed

exp: generate random experiment names at start of each experiment #8650

dberenbaum opened this issue Dec 1, 2022 · 3 comments · Fixed by #8659
Assignees
@daavoo
Labels
A: experiments Related to dvc exp p2-medium Medium priority, should be done, but less important

Comments

@dberenbaum
Copy link
Collaborator

Move the logic from dvclive in https://github.com/iterative/dvclive/blob/127cbd4dd7f55ca573c0c45bb90073cada93e87f/src/dvclive/dvc.py#L80 to dvc to assign a human-readable experiment name at the start of each experiment.
@dberenbaum dberenbaum added p2-medium Medium priority, should be done, but less important A: experiments Related to dvc exp labels Dec 1, 2022
@shcheklein
Copy link
Member

Can we do this as a p1? Otherwise I feel we'll start on this soon in VS Code independently :) If we agree on this path it's better to do it now I think.

@daavoo
Copy link
Contributor

daavoo commented Dec 2, 2022

I have already started because is also convenient for the live metrics proposal. Unless I am missing something it should be ready this sprint

@shcheklein
Copy link
Member

Thanks @daavoo !!

daavoo added a commit that referenced this issue Dec 5, 2022
@daavoo
exp: Generate a human-readable name beforehand.
f566c5b 
- Move `hash_exp` from experiment completion to experiment creation.

Change implementation to rely on `deps` and `params`(including overrides).
The existing implementation generated the hash based on the lock of stages executed during the experiment.
Hopefully, this doesn't break anything (it doesn't break tests).

- Add `get_random_name` utils.
Use `hash_exp` result as seed.

- Remove logic using `exp_hash` for completion checks.
Replace `exp_hash: Optional[str]` with `completed: bool = False`.

Closes #8650
daavoo added a commit that referenced this issue Dec 5, 2022
@daavoo
exp: Generate a human-readable name beforehand.
cf12746 
- Move `hash_exp` from experiment completion to experiment creation.

Change implementation to rely on `deps` and `params`(including overrides).
The existing implementation generated the hash based on the lock of stages executed during the experiment.
Hopefully, this doesn't break anything (it doesn't break tests).

- Add `get_random_name` utils.
Use `hash_exp` result as `seed`.

- Remove logic using `exp_hash` for completion checks.
Replace `exp_hash: Optional[str]` with `completed: bool = False`.

Closes #8650
@daavoo daavoo mentioned this issue Dec 5, 2022
Merged
daavoo added a commit that referenced this issue Dec 5, 2022
@daavoo
exp: Generate a human-readable name beforehand.
f6f771d 
- Move `hash_exp` from experiment completion to experiment creation.

Change implementation to rely on `deps` and `params`(including overrides).
The existing implementation generated the hash based on the lock of stages executed during the experiment.
Hopefully, this doesn't break anything (it doesn't break tests).

- Add `get_random_name` utils.
Use `hash_exp` result as `seed`.

- Remove logic using `exp_hash` for completion checks.
Replace `exp_hash: Optional[str]` with `completed: bool = False`.

Closes #8650
daavoo added a commit that referenced this issue Dec 5, 2022
@daavoo
exp: Generate a human-readable name beforehand.
fb43951 
- Move `hash_exp` from experiment completion to experiment creation.

Change implementation to rely on `deps` and `params`(including overrides).
The existing implementation generated the hash based on the lock of stages executed during the experiment.
Hopefully, this doesn't break anything (it doesn't break tests).

- Add `get_random_name` utils.
Use `hash_exp` result as `seed`.

- Remove logic using `exp_hash` for completion checks.
Replace `exp_hash: Optional[str]` with `completed: bool = False`.

Closes #8650
daavoo added a commit that referenced this issue Dec 5, 2022
@daavoo
exp: Generate a human-readable name beforehand.
1a14617 
- Move `hash_exp` from experiment completion to experiment creation.

Change implementation to rely on `deps` and `params`(including overrides).
The existing implementation generated the hash based on the lock of stages executed during the experiment.
Hopefully, this doesn't break anything (it doesn't break tests).

- Add `get_random_name` utils.
Use `hash_exp` result as `seed`.

- Remove logic using `exp_hash` for completion checks.
Replace `exp_hash: Optional[str]` with `completed: bool = False`.

Closes #8650
daavoo added a commit that referenced this issue Dec 7, 2022
@daavoo
exp: Generate a human-readable name beforehand.
dece909 
- Remove `hash_exp`.
#8669

- Add `get_random_exp_name` to utils.
Generates a name (`f"{adjective}-{noun}"`) by randomly chosing pairs of adjetive, noun.
Recieves `scm` and `baseline_rev` and retries the random choice until a non-existing ref is found.

- Update logic using `exp_hash` for completion checks.
Replace `exp_hash: Optional[str]` with `completed: bool = False`.

Closes #8650
daavoo added a commit that referenced this issue Dec 7, 2022
@daavoo
exp: Generate a human-readable name beforehand.
b11604e 
- Remove `hash_exp`.
#8669

- Add `get_random_exp_name` to utils.
Generates a name (`f"{adjective}-{noun}"`) by randomly chosing pairs of adjetive, noun.
Recieves `scm` and `baseline_rev` and retries the random choice until a non-existing ref is found.

- Update logic using `exp_hash` for completion checks.
Replace `exp_hash: Optional[str]` with `completed: bool = False`.

Closes #8650
daavoo added a commit that referenced this issue Dec 9, 2022
@daavoo
exp: Generate a human-readable name beforehand.
75e9e28 
- Add `get_random_exp_name` to utils.
Generates a name (`f"{adjective}-{noun}"`) by randomly chosing pairs of adjetive, noun.
Recieves `scm` and `baseline_rev` and retries the random choice until a non-existing ref is found.

Closes #8650
daavoo added a commit that referenced this issue Dec 9, 2022
@daavoo
exp: Generate a human-readable name beforehand.
4f51a0d 
- Add `get_random_exp_name` to utils.
Generates a name (`f"{adjective}-{noun}"`) by randomly chosing pairs of adjetive, noun.
Recieves `scm` and `baseline_rev` and retries the random choice until a non-existing ref is found.

Closes #8650
daavoo added a commit that referenced this issue Dec 9, 2022
@daavoo
exp: Generate a human-readable name beforehand.
bb75126 
- Add `get_random_exp_name` to utils.
Generates a name (`f"{adjective}-{noun}"`) by randomly chosing pairs of adjetive, noun.
Recieves `scm` and `baseline_rev` and retries the random choice until a non-existing ref is found.

Closes #8650
karajan1001 pushed a commit to karajan1001/dvc that referenced this issue Dec 10, 2022
@daavoo @karajan1001
exp: Generate a human-readable name beforehand.
ac6c99d 
- Add `get_random_exp_name` to utils.
Generates a name (`f"{adjective}-{noun}"`) by randomly chosing pairs of adjetive, noun.
Recieves `scm` and `baseline_rev` and retries the random choice until a non-existing ref is found.

Closes iterative#8650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daavoo daavoo

Labels
A: experiments Related to dvc exp p2-medium Medium priority, should be done, but less important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exp: Generate a human-readable name beforehand. iterative/dvc
3 participants
@dberenbaum @shcheklein @daavoo