Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine: machine list Make name arguments optional and show all machines when it was not provided. #6804

Closed
karajan1001 opened this issue Oct 14, 2021 · 2 comments
Labels
A: executors Related to the executors feature feature request Requesting a new feature ui user interface / interaction

Comments

@karajan1001
Copy link
Contributor

@karajan1001 Another minor UI tweak is that we need to make clear that the positional arguments are optional and all machines will be shown by default.

Originally posted by @dberenbaum in #6602 (comment)

@daavoo daavoo added A: executors Related to the executors feature feature request Requesting a new feature labels Oct 20, 2021
@karajan1001
Copy link
Contributor Author

@dberenbaum, Look into the code and the test on my local machine, I found that it had already been supported. And we had already had a test of it.

assert main(["machine", "list"]) == 0
cap = capsys.readouterr()
assert "cloud=azure" in cap.out
assert main(["machine", "list", "foo"]) == 0
cap = capsys.readouterr()
assert "cloud=azure" not in cap.out
assert "cloud=aws" in cap.out

@dberenbaum
Copy link
Collaborator

@karajan1001 Thanks, but I meant here that we need to document that behavior in the help message.

Compare to dvc stage list --help output:

$ dvc stage list --help
usage: dvc stage list [-h] [-q | -v] [--all] [--fail] [-R] [--names-only]
                      [targets ...]

List stages.
Documentation: <https://man.dvc.org/stage/list>

positional arguments:
  targets          Show stages from a dvc.yaml/.dvc file or a directory. 'dvc.yaml' by
                   default

@karajan1001 karajan1001 reopened this Oct 26, 2021
@karajan1001 karajan1001 added ui user interface / interaction good first issue and removed good first issue labels Oct 26, 2021
karajan1001 added a commit to karajan1001/dvc that referenced this issue Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: executors Related to the executors feature feature request Requesting a new feature ui user interface / interaction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants