Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safe Dvcfile.dump() #4235

Closed
skshetry opened this issue Jul 18, 2020 · 3 comments · Fixed by #4544
Closed

safe Dvcfile.dump() #4235

skshetry opened this issue Jul 18, 2020 · 3 comments · Fixed by #4544
Assignees
@skshetry
Labels
enhancement Enhances DVC p1-important Important, aka current backlog of things to do refactoring Factoring and re-factoring

Comments

@skshetry
Copy link
Member

Initially, the idea was not to touch dvc.yaml at all, but as we are doing it quite often, it's better to protect dvc.lock rather than dvc.yaml by default.
So, we could change it to the following default:

def dump(pipeline=True, lock=False):
    pass

The only place where we need to update lock are dvc repro and dvc run, at least atm.

Originally posted by @skshetry in #3994 (comment)
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Jul 18, 2020
@skshetry skshetry self-assigned this Jul 18, 2020
@efiop
Copy link
Contributor

efiop commented Jul 18, 2020

@skshetry Is this something that you are tackling right now(judging by the assignee)? If not, could you please elaborate a bit more? Also, please feel free to set appropriate labels.

@weekly-digest weekly-digest bot mentioned this issue Jul 19, 2020
Closed
@skshetry
Copy link
Member Author

I'm not working right now, but something that I'd like to tackle next.
#3994 (comment) should have enough context about the issue.

@efiop
Copy link
Contributor

efiop commented Jul 19, 2020

@skshetry What about labels then?

@skshetry skshetry added enhancement Enhances DVC p1-important Important, aka current backlog of things to do refactoring Factoring and re-factoring labels Jul 20, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Jul 20, 2020
skshetry added a commit to skshetry/dvc that referenced this issue Sep 8, 2020
@skshetry
dvc: change dvcfile.dump to do synchronized dump by default
c0dc058 
The API of `Dvcfile.dump` has been changed to
`dump(stage, update_pipeline=True, update_lock=True)`,
which will make it to always dump by default to both files,
and provide flags to suppress one or the other.

Fixes iterative#4235
@skshetry skshetry mentioned this issue Sep 8, 2020
Merged
2 tasks
skshetry added a commit that referenced this issue Sep 10, 2020
@skshetry
dvc: change dvcfile.dump to do synchronized dump by default (#4544)
2931d30 
The API of `Dvcfile.dump` has been changed to
`dump(stage, update_pipeline=True, update_lock=True)`,
which will make it to always dump by default to both files,
and provide flags to suppress one or the other.

Fixes #4235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skshetry skshetry

Labels
enhancement Enhances DVC p1-important Important, aka current backlog of things to do refactoring Factoring and re-factoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dvc: change Dvcfile.dump to be synchronized by default skshetry/dvc
2 participants
@efiop @skshetry